Horton
Menu

Re: Miscellaneous changes to plperl [PATCH]

David E. Wheeler <david@kineticode.com>

View thread
From: "David E. Wheeler" <david@kineticode.com>
To: Alex Hunsaker <badalex@gmail.com>
Cc: Tim Bunce <Tim.Bunce@pobox.com>, pgsql-hackers@postgresql.org
Date: 2010-01-23T19:42:59Z
Lists: pgsql-hackers 
On Jan 23, 2010, at 11:20 AM, Alex Hunsaker wrote:

> Well no, i suppose we could fix that via:
> $name =~ s/[:|']/_/g;
> 
> Im betting that was the intent.

Doubtful. In Perl, the package separator is either `::` or `'` (for hysterical reasons). So the original code was replacing any package separator with a single underscore. Your regex would change This::Module to This__Module, which I'm certain was not the intent.

Best,

David