Horton

Re: pg_upgrade fails to detect unsupported arrays and ranges

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Tomas Vondra <tomas.vondra@2ndquadrant.com>
Date: 2019-11-10T22:39:14Z
Lists: pgsql-hackers 
> On 10 Nov 2019, at 22:12, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Daniel Gustafsson <daniel@yesql.se> writes:
>> On 10 Nov 2019, at 20:07, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> (Note: this patch is shown with --ignore-space-change
>>> to make it more reviewable, but I did re-pgindent the code.)  Then
>>> 0002 actually adds the array and range cases.
> 
>> Was the source pgindented, but not committed, before generating the patches?  I
>> fail to apply them on master (or REL_12_STABLE) on what seems to be only
>> whitespace changes.
> 
> Hm, I suppose it might be hard to apply the combination of the patches
> (maybe something involving patch -l would work).  For simplicity, here's
> the complete patch for HEAD.  I fixed a missing schema qualification.

Applies, builds clean and passes light testing.  I can see the appeal of
including it before the wrap, even though I personally would've held off.

cheers ./daniel

Commits

  1. Improve wording of some pg_upgrade failure reports.

  2. Fix some more omissions in pg_upgrade's tests for non-upgradable types.

  3. Handle arrays and ranges in pg_upgrade's test for non-upgradable types.