Horton

Re: doc: create table improvements

Chao Li <li.evan.chao@gmail.com>

View thread
From: Chao Li <li.evan.chao@gmail.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, jian he <jian.universality@gmail.com>
Date: 2025-12-16T02:14:00Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: declutter CREATE TABLE synopsis.

  2. Remove support for unlogged on partitioned tables


> On Oct 23, 2025, at 12:43, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> 
> On Mon, 2025-10-20 at 07:41 -0400, David G. Johnston wrote:
>> I question whether “parameter” is even the correct class to assign here
>> and so would rather avoid the issue by not assigning a class.
> 
> Right.  I have removed the vestiges from my failed attempt to improve
> the "parameter" decorations.
> 
>> “If none is specified, the data will be persistent” would be better
>> written “If unspecified the data will be persistent” (or, “if not specified…”)
> 
> I decided to use the trusted phrasing "by default".
> 
>> Everything else looks good.
> 
> Patch attached; if it is fine with you, I'll mark it "ready for committer".
> 
> Yours,
> Laurenz Albe
> <v4-0001-Unclutter-CREATE-TABLE-synopsis.patch>

Overall the change looks good to me. I have only one comment about the naming of “oversize_storage”. Why not just “storage_parameters” or similar that sounds more straightforward?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/