Re: add timing information to pg_upgrade

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2023-08-22T09:49:33Z
Lists: pgsql-hackers
On 01.08.23 17:45, Nathan Bossart wrote:
> On Tue, Aug 01, 2023 at 09:46:02AM +0200, Peter Eisentraut wrote:
>> On 31.07.23 20:37, Nathan Bossart wrote:
>>> -	prep_status("Checking for incompatible \"aclitem\" data type in user tables");
>>> +	prep_status("Checking for \"aclitem\" data type in user tables");
>>
>> Why these changes?  I think this is losing precision about what it's doing.
> 
> The message is too long, so there's no space between it and the "ok"
> message:
> 
> 	Checking for incompatible "aclitem" data type in user tablesok
> 
> Instead of altering the messages, we could bump MESSAGE_WIDTH from 60 to
> 62 or 64.  Do you prefer that approach?  (BTW this probably needs to be
> back-patched to v16.)

Let's change MESSAGE_WIDTH to 62 in v16, and then pursue the larger 
restructuring leisurely.




Commits

  1. pg_upgrade: Bump MESSAGE_WIDTH.