Horton

Thread

Commits

  1. pg_dump: Remove query truncation in error messages

  1. pg_dump truncating queries in error messages

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2017-03-26T19:26:23Z

    When reporting an error from a query, pg_dump truncates the reported
query to 128 characters (pg_backup_db.c ExecuteSqlCommand()).

Is this (still) sensible?  The kind of queries that pg_dump is running
nowadays, I find myself unable to debug them if they are truncated at
that length.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  2. Re: pg_dump truncating queries in error messages

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-03-26T20:09:38Z

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> When reporting an error from a query, pg_dump truncates the reported
> query to 128 characters (pg_backup_db.c ExecuteSqlCommand()).

> Is this (still) sensible?  The kind of queries that pg_dump is running
> nowadays, I find myself unable to debug them if they are truncated at
> that length.

Not clear that it ever was very sensible ... +1 for removing the limit.

			regards, tom lane

  3. Re: pg_dump truncating queries in error messages

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2017-03-29T19:21:54Z

    On 3/26/17 16:09, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> When reporting an error from a query, pg_dump truncates the reported
>> query to 128 characters (pg_backup_db.c ExecuteSqlCommand()).
> 
>> Is this (still) sensible?  The kind of queries that pg_dump is running
>> nowadays, I find myself unable to debug them if they are truncated at
>> that length.
> 
> Not clear that it ever was very sensible ... +1 for removing the limit.

OK done.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services