Re: uintptr_t for Datum
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2009-12-31T16:40:48Z
Lists: pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes: > Attached patch is the part of the win64 patch that changes Datum to be > uintptr_t, and associated changes, with only very minor changes from > me. It also includes autoconf tests that I tricked Bruce into fixing > for me :-) > Comments? This is a joke no? Where's the logic to provide a definition of intptr_t if the platform fails to? The lack of attention to updating the comments about Datum doesn't give me a warm feeling either. BTW, it looks like the patch is showing a manual change to pg_config.h.in. Don't do that. Run autoheader. regards, tom lane