Horton

Re: WIP: Covering + unique indexes.

Anastasia Lubennikova <a.lubennikova@postgrespro.ru>

View thread View on postgr.es
From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Teodor Sigaev <teodor@sigaev.ru>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Anastasia Lubennikova <lubennikovaav@gmail.com>, Peter Geoghegan <pg@heroku.com>, David Steele <david@pgmasters.net>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Aleksander Alekseev <a.alekseev@postgrespro.ru>
Date: 2017-03-31T18:28:10Z
Lists: pgsql-hackers 
31.03.2017 20:57, Robert Haas:
> On Fri, Mar 31, 2017 at 1:40 PM, Anastasia Lubennikova
> <a.lubennikova@postgrespro.ru> wrote:
>> First of all, I want to thank you and Robert for reviewing this patch.
>> Your expertise in postgres subsystems is really necessary for features like
>> this.
>> I just wonder, why don't you share your thoughts and doubts till the "last
>> call".
> I haven't done any significant technical work other than review
> patches in 14 months, and in the last several months I've often worked
> 10 and 12 hour days to get more review done.
>
> I think at one level you've got a fair complaint here - it's hard to
> get things committed, and this patch probably didn't get as much
> attention as it deserved.  It's not so easy to know how to fix that.
> I'm pretty sure "tell Andres and Robert to work harder" isn't it.
>

*off-topic*
No complaints from me, I understand how difficult is reviewing and 
highly appreciate your work.
The problem is that not all developers are qualified enough to do a review.
I've tried to make a course about postrges internals. Something like 
"Deep dive into postgres codebase for hackers".
And it turned out to be really helpful for new developers. So, I wonder, 
maybe we could write some tips for new reviewers and testers as well.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Adjust INCLUDE index truncation comments and code.

  2. Add commentary explaining why MaxIndexTuplesPerPage calculation is safe.

  3. Indexes with INCLUDE columns and their support in B-tree

  4. Add amcheck verification of heap relations belonging to btree indexes.

  5. Doc: move info for btree opclass implementors into main documentation.

  6. Doc: mention that you can't PREPARE TRANSACTION after NOTIFY.

  7. Remove dedicated B-tree root-split record types.

  8. Restructure index access method API to hide most of it at the C level.

  9. Split _bt_insertonpg to two functions.

  10. Major overhaul of btree index code. Eliminate special BTP_CHAIN logic for