Horton

Re: [Proposal] Global temporary tables

曾文旌 (义从) <wenjing.zwj@alibaba-inc.com>

View thread
From: 曾文旌 <wenjing.zwj@alibaba-inc.com>
To: tushar <tushar.ahuja@enterprisedb.com>
Cc: Prabhat Sahu <prabhat.sahu@enterprisedb.com>, Pavel Stehule <pavel.stehule@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Konstantin Knizhnik <k.knizhnik@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, "蔡松露(子嘉)" <zijia@taobao.com>, "Cai, Le" <le.cai@alibaba-inc.com>, "萧少聪(铁庵)" <shaocong.xsc@alibaba-inc.com>
Date: 2020-03-31T04:11:58Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. PageAddItemExtended(): Add LP_UNUSED assertion.

  2. Remove temporary files after backend crash

  3. Fix comment in indexing.c

  4. Fix failure to ignore leftover temp tables after a server crash.


> 2020年3月27日 下午6:06，tushar <tushar.ahuja@enterprisedb.com> 写道：
> 
> On 3/27/20 10:55 AM, 曾文旌 wrote:
>>> Hi Wenjing,
>>> This patch(gtt_v21_pg13.patch) is not applicable on PG HEAD, I hope you have prepared the patch on top of some previous commit. 
>>> Could you please rebase the patch which we can apply on HEAD ?
>> Yes, It looks like the built-in functions are in conflict with new code.
>> 
> In this below scenario, pg_dump is failing -
> 
> test=# CREATE database foo;
> CREATE DATABASE
> test=# \c foo
> You are now connected to database "foo" as user "tushar".
> foo=# CREATE GLOBAL TEMPORARY TABLE bar(c1 bigint, c2 bigserial) on commit PRESERVE rows;
> CREATE TABLE
> foo=# \q
> 
> [tushar@localhost bin]$ ./pg_dump -Fp foo > /tmp/rf2
> pg_dump: error: query to get data of sequence "bar_c2_seq" returned 0 rows (expected 1)
> [tushar@localhost bin]$ 
> 
> 
Thanks for review
Fixed in global_temporary_table_v23-pg13.patch



Wenjing





> -- 
> regards,tushar
> EnterpriseDB  https://www.enterprisedb.com/ <https://www.enterprisedb.com/>
> The Enterprise PostgreSQL Company