Horton

Re: PostgreSQL crashes with SIGSEGV

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Aleksandr Parfenov <a.parfenov@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-01-17T21:00:16Z
Lists: pgsql-bugs, pgsql-hackers 
Peter Geoghegan <pg@bowt.ie> writes:
> On Wed, Jan 17, 2018 at 12:31 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> +1.  If the problem isn't known to be reproducible in those branches,
>> the risk of adding new bugs seems to outweigh any benefit.

> You could make the same objection to changing tuplesort_getdatum()
> outside of the master branch, though. I think that going back further
> than that for the (arguably independent) tuplesort_getdatum() subset
> fix might still be a good idea. I wonder where you stand on this.

I haven't been following the thread very closely, so I don't have an
opinion on that.

			regards, tom lane

Commits

  1. Fix actual and potential double-frees around tuplesort usage.

  2. Allow the built-in ordered-set aggregates to share transition state.

  3. Avoid integer overflow while sifting-up a heap in tuplesort.c.

  4. Allow avoiding tuple copy within tuplesort_gettupleslot().

  5. Remove should_free arguments to tuplesort routines.

  6. Fix use-after-free around DISTINCT transition function calls.

  7. Reuse abbreviated keys in ordered [set] aggregates.