Horton

Re: BUG #15248: pg_upgrade fails when a function with an empty search_path is encountered

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-bugs@lists.postgresql.org
Cc: steven.winfield@cantabcapital.com, Michael Paquier <michael@paquier.xyz>
Date: 2018-07-30T20:21:59Z
Lists: pgsql-bugs

Attachments

I wrote:
> So it seems like what we have to do here is to teach pg_dump and ruleutils
> to parse a GUC_LIST_QUOTE value the same way SplitIdentifierString does,
> and then quote each extracted list element as a string literal.  Bleah.
> It's not *that* much code, but it's annoying, especially because of the
> duplicated logic.

Here's a proposed patch for this.  As I feared, there's kind of a lot of
code duplication :-(.  I thought for awhile about trying to unify the four
copies of the split-on-delimiters code into one function with a bunch of
option flags ... but it seemed like that would be pretty messy too, so I
desisted.

			regards, tom lane

Commits

  1. Further fixes for quoted-list GUC values in pg_dump and ruleutils.c.