Re: ecpg_config.h symbol missing with meson
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-04-24T06:32:26Z
Lists: pgsql-hackers
On 17.04.24 18:15, Tom Lane wrote: > Peter Eisentraut <peter@eisentraut.org> writes: >> I checked the generated ecpg_config.h with make and meson, and the meson >> one is missing > >> #define HAVE_LONG_LONG_INT 1 > >> This is obviously quite uninteresting, since that is required by C99. >> But it would be more satisfactory if we didn't have discrepancies like >> that. Note that we also kept ENABLE_THREAD_SAFETY in ecpg_config.h for >> compatibility. >> ... >> Alternatively, we could remove the symbol from the make side. > > Think I'd vote for removing it, since we use it nowhere. > The ENABLE_THREAD_SAFETY precedent feels a little bit different, > since there's not the C99-requires-the-feature angle. Ok, fixed by removing instead.
Commits
-
Remove obsolete symbol from ecpg_config.h.in
- c3fa85b249e4 17.0 landed