Horton

Re: Rename of triggers for partitioned tables

Arne Roland <a.roland@index.de>

View thread View on postgr.es
From: Arne Roland <A.Roland@index.de>
To: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-11-27T00:19:57Z
Lists: pgsql-hackers

Attachments

I'm sorry for the spam. Here a patch with updated comments, I missed one before.


Regards

Arne

________________________________
From: Arne Roland <A.Roland@index.de>
Sent: Friday, November 27, 2020 1:05:02 AM
To: Pg Hackers
Subject: Re: Rename of triggers for partitioned tables


I'm too unhappy with the interface change, so please view attached patch instead.


Regards

Arne

________________________________
From: Arne Roland <A.Roland@index.de>
Sent: Friday, November 27, 2020 12:28:31 AM
To: Pg Hackers
Subject: Rename of triggers for partitioned tables


Hello,


I got too annoyed at building queries for gexec all the time. So wrote a patch to fix the issue that the rename of partitioned trigger doesn't affect children.


In case there isn't a dependent trigger with the same name on the child the function errors out. If the user touched the trigger of the child, it's not a sensitive idea to mess with it.


I'm not happy with the interface change in trigger.h. Yet I don't like the idea of creating another layer of indirection either.


Even though it's a small patch, there might be other things I'm missing, so I'd appreciate feedback.


Regards

Arne

Commits

  1. Remove newly added useless assertion check

  2. Make ALTER TRIGGER RENAME consistent for partitioned tables

  3. Fix pg_dump for disabled triggers on partitioned tables

  4. Preserve firing-on state when cloning row triggers to partitions

  5. Fix ALTER TABLE .. ENABLE/DISABLE TRIGGER recursion

  6. Record parents of triggers

  7. Allow FOR EACH ROW triggers on partitioned tables