Horton

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

Chapman Flack <chap@anastigmatix.net>

View thread View on postgr.es
From: Chapman Flack <chap@anastigmatix.net>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>, Magnus Hagander <magnus@hagander.net>, David Steele <david@pgmasters.net>, pgsql-hackers@lists.postgresql.org
Date: 2022-03-11T00:13:14Z
Lists: pgsql-hackers 
On 03/09/22 19:06, Nathan Bossart wrote:
> Done.  I went ahead and added "label => 'label'" for consistency.

Looks like this change to an example in func.sgml is not quite right:

-postgres=# SELECT * FROM pg_walfile_name_offset(pg_stop_backup());
+postgres=# SELECT * FROM pg_walfile_name_offset(pg_backup_stop());

pg_backup_stop returns a record now, not just lsn. So this works for me:

+postgres=# SELECT * FROM pg_walfile_name_offset((pg_backup_stop()).lsn);


Otherwise, all looks to be in good order.

Regards,
-Chap

Commits

  1. Remove duplicated word in comment of basebackup.c