Horton

Re: Improve a few appendStringInfo calls new to v18

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: David Rowley <dgrowleyml@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-11T07:07:04Z
Lists: pgsql-hackers 
On 10.04.25 05:51, David Rowley wrote:
> Looks like v18 has grown a few appendStringInfo misusages, e.g. using
> appendStringInfo() when no formatting is needed or just using format
> "%s" instead of using appendStringInfoString().

Would it be useful to augment appendStringInfo() something like this:

if (VA_ARGS_NARGS() == 0)
     return appendStringInfoString(str, fmt);

?

Commits

  1. Improve various new-to-v18 appendStringInfo calls

  2. Fixup various StringInfo function usages