Thread

1. pgsql: Cleanup comments/docs around the new shmem request callbacks

   Heikki Linnakangas <heikki.linnakangas@iki.fi> — 2026-07-07T19:40:07Z

   Cleanup comments/docs around the new shmem request callbacks
   
   Make it explicit in the docs that the shmem initialization callbacks
   are called while holding ShmemIndexLock.
   
   Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
   Discussion: https://www.postgresql.org/message-id/CAExHW5sHs+eSiTDOd14buayc6JbBX=Hm5ssFMBK0Ki9sTGEOuA@mail.gmail.com
   Backpatch-through: 19
   
   Branch
   ------
   REL_19_STABLE
   
   Details
   -------
   https://git.postgresql.org/pg/commitdiff/a53d6d8aea8fe703d86dd2bdc0a3d86800eca7c3
   
   Modified Files
   --------------
   doc/src/sgml/xfunc.sgml         | 4 ++--
   src/backend/storage/ipc/shmem.c | 7 +++++--
   2 files changed, 7 insertions(+), 4 deletions(-)
   
   

2. Re: pgsql: Cleanup comments/docs around the new shmem request callbacks

   Erik Rijkers <er@xs4all.nl> — 2026-07-08T02:26:10Z

   Op 7/7/26 om 21:40 schreef Heikki Linnakangas:
   > Cleanup comments/docs around the new shmem request callbacks
   > 
   > Make it explicit in the docs that the shmem initialization callbacks
   > are called while holding ShmemIndexLock.
   > 
   > Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
   > Discussion: https://www.postgresql.org/message-id/CAExHW5sHs+eSiTDOd14buayc6JbBX=Hm5ssFMBK0Ki9sTGEOuA@mail.gmail.com
   > Backpatch-through: 19
   > 
   > Branch
   > ------
   > REL_19_STABLE
   > 
   > Details
   > -------
   > https://git.postgresql.org/pg/commitdiff/a53d6d8aea8fe703d86dd2bdc0a3d86800eca7c3
   > 
   > Modified Files
   > --------------
   > doc/src/sgml/xfunc.sgml         | 4 ++--
   
   Hi,
   
   in doc/src/sgml/xfunc.sgml
   
   the sentence:
      "two backends trying to initializing the memory area"
   
   should be:
      "two backends trying to initialize the memory area"
   
   Thanks,
   
   
   Erik
   
   
   > src/backend/storage/ipc/shmem.c | 7 +++++--
   > 2 files changed, 7 insertions(+), 4 deletions(-)
   > 
   
   
   
   

3. Re: pgsql: Cleanup comments/docs around the new shmem request callbacks

   Heikki Linnakangas <hlinnaka@iki.fi> — 2026-07-08T07:25:27Z

   On 08/07/2026 05:26, Erik Rijkers wrote:
   > in doc/src/sgml/xfunc.sgml
   > 
   > the sentence:
   >    "two backends trying to initializing the memory area"
   > 
   > should be:
   >    "two backends trying to initialize the memory area"
   
   Fixed, thanks!
   
   - Heikki