Re: contrib/sepgsql regression tests have been broken for months
Joe Conway <mail@joeconway.com>
From: Joe Conway <mail@joeconway.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
Jacob Champion <jacob.champion@enterprisedb.com>,
pgsql-hackers@lists.postgresql.org
Date: 2025-11-01T12:50:53Z
Lists: pgsql-hackers
On 10/31/25 15:48, Tom Lane wrote: > Joe Conway <mail@joeconway.com> writes: >> On 10/29/25 19:36, Tom Lane wrote: >>> ... I think the new idea >>> is to leave the module installed and active, which is kind >>> of problematic if we want to also use TestSepgsql.pm in the >>> back branches. > >> I suppose one solution is to create a new buildfarm animal and then use >> rhino only for <= pg17 and <rhino-prime> only for pg18+ > > It looks like it'd work to revert to using TestSepgsql.pm in all > branches. You'd need to remove 'sepgsql' from PG_TEST_EXTRA so > that v18/master don't try to run the conflicting 001_sepgsql.pl > tests. I'm not clear on whether this involves just undoing the recent changes I made, or if the buildfarm code itself needs changes. FWIW I did this part: > remove 'sepgsql' from PG_TEST_EXTRA But what about "--enable-tap-tests"? That makes the full buildfarm cycle across all branches take something like 2.5 hours. I removed that part for now at least. > We need a better idea about how the new test method can coexist > with the old one, but for now I'd just like rhino to be running > one or the other successfully ... ok, back to the original configuration (although now with the latest buildfarm client) -- Joe Conway PostgreSQL Contributors Team Amazon Web Services: https://aws.amazon.com
Commits
-
Update expected output for contrib/sepgsql's regression tests.
- 67ef5575ccb0 18.1 landed
- 0758111f5d35 19 (unreleased) landed
-
Print out error position for some ALTER TABLE ALTER COLUMN type
- 65281391a937 18.0 cited