Re: add __attribute__((noreturn)) to suppress a waring
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Itagaki Takahiro <itagaki.takahiro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2011-01-24T15:14:42Z
Lists: pgsql-hackers
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes: > On 24.01.2011 03:42, Itagaki Takahiro wrote: >> To suppress it, I'm thinking to add noreturn to die_horribly(). >> Any objections? Another solution might be adding a dummy assignment >> after calls of die_horribly(). > I added a dummy assignment, that's how we've handled this before in > pg_dump. We generally do *not* want to depend on noreturn, because it will not suppress similar warnings in non-gcc compilers. Just add a dummy initialization, or reorganize the code to avoid the problem. regards, tom lane