Re: Add missing includes
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tristan Partin <tristan@neon.tech>, pgsql-hackers@postgresql.org
Date: 2023-05-22T15:28:19Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > On 2023-May-22, Tristan Partin wrote: >> Some files were missing information from the c.h header. > Actually, these omissions are intentional, and we have bespoke handling > for this in our own header-checking scripts (src/tools/pginclude). I > imagine this is documented somewhere, but ATM I can't remember where. > (And if not, maybe that's something we should do.) Yeah, the general policy is that .h files should not explicitly include c.h (nor postgres.h nor postgres_fe.h). Instead, .c files should include the appropriate one of those three files first. This allows sharing of .h files more easily across frontend/backend/common environments. I'm not sure where this is documented either. regards, tom lane
Commits
-
Doc: update src/tools/pginclude/README.
- be3f62ae6e98 16.0 landed