Re: log chunking broken with large queries under load

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-04-02T16:00:14Z
Lists: pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 04/01/2012 06:34 PM, Andrew Dunstan wrote:
>> Some of my PostgreSQL Experts colleagues have been complaining to me 
>> that servers under load with very large queries cause CSV log files 
>> that are corrupted,

> We could just increase CHUNK_SLOTS in syslogger.c, but I opted instead 
> to stripe the slots with a two dimensional array, so we didn't have to 
> search a larger number of slots for any given message. See the attached 
> patch.

This seems like it isn't actually fixing the problem, only pushing out
the onset of trouble a bit.  Should we not replace the fixed-size array
with a dynamic data structure?

			regards, tom lane