Re: New "blob" re-introduced?

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-02-24T07:38:44Z
Lists: pgsql-hackers
> On 24 Feb 2023, at 08:31, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:

> Shouldn't we use "large object" instead of "blob" in the message?

Nice catch, it should be "large object" as per the linked discussion.  There
are also a few more like:

-       if (cfclose(ctx->LOsTocFH) != 0)
-               pg_fatal("could not close LOs TOC file: %m");
+       if (EndCompressFileHandle(ctx->LOsTocFH) != 0)
+               pg_fatal("could not close blobs TOC file: %m");

I'll go ahead and fix them, thanks for the report!

--
Daniel Gustafsson




Commits

  1. pg_dump: Remove move "blob" terminology

  2. Introduce a generic pg_dump compression API

  3. pg_dump: Remove "blob" terminology