Re: tests fail on windows with default git settings

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Dave Page <dpage@pgadmin.org>
Date: 2024-07-07T05:26:13Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> Do we want to support checking out with core.autocrlf?

-1.  It would be a constant source of breakage, and you could never
expect that (for example) making a tarball from such a checkout
would match anyone else's results.

> If we do not want to support that, ISTM we ought to raise an error somewhere?

+1, if we can figure out how.

			regards, tom lane



Commits

  1. Use diff --strip-trailing-cr in pg_regress.c

  2. Use diff's --strip-trailing-cr flag where appropriate on Windows