Re: Convert *GetDatum() and DatumGet*() macros to inline functions

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-09-12T15:59:09Z
Lists: pgsql-hackers
On 08.09.22 11:26, Aleksander Alekseev wrote:
>>> 3. Go with your patch and just fix up the warnings about uninitialized
>>> variables.  But that seems the least principled to me.
>>
>> IMO the 3rd option is the lesser evil. Initializing four bools/ints in
>> order to make Clang 11 happy doesn't strike me as such a big deal. At
>> least until somebody reports a bottleneck for this particular reason.
>> We can optimize the code when and if this will happen.
> 
> Since the first patch was applied, cfbot now complains that it can't
> apply the patchset. Here is the rebased version.

committed, thanks




Commits

  1. Convert *GetDatum() and DatumGet*() macros to inline functions

  2. Fix incorrect uses of Datum conversion macros