Re: Negotiating the SCRAM channel binding type

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-08-05T14:15:19Z
Lists: pgsql-hackers
On 05/08/18 17:11, I wrote:
> The only negative test there was, was to check for bogus
> scram_channel_binding option, "scram_channel_binding=not-exists". Yeah,
> it would be nice to have some, but this commit didn't really change that
> situation.

Sorry, I see now that there was indeed a test for 
scram_channel_binding='', which meant "no channel binding". That was 
confusing, I assumed '' was the default.

> I'm hoping that we add a libpq option to actually force channel binding
> soon. That'll make channel binding actually useful to users, but it will
> also make it easier to write tests to check that channel binding is
> actually used or not used, in the right situations.

Nevertheless, this we should do.

- Heikki


Commits

  1. Remove support for tls-unique channel binding.