Horton

Re: Vacuum statistics

Alena Rybakina <lena.ribackina@yandex.ru>

View thread
From: Alena Rybakina <lena.ribackina@yandex.ru>
To: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Jim Nasby <jnasby@upgrade.com>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Kirill Reshke <reshkekirill@gmail.com>, Andrei Zubkov <zubkov@moonset.ru>, Masahiko Sawada <sawada.mshk@gmail.com>, Melanie Plageman <melanieplageman@gmail.com>, jian he <jian.universality@gmail.com>, a.lepikhov@postgrespro.ru, Sami Imseih <samimseih@gmail.com>, vignesh C <vignesh21@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-09-25T13:53:09Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move wal_buffers_full from PgStat_PendingWalStats to WalUsage

Attachments

Hi! Thank you for reviewing it.

My email hasn’t been working properly recently, so I missed your letter 
— sorry about that.

Yes, I completely agree with your proposed fix and have included it in 
the updated version of the patch.

Just to remind you, this version stores vacuum statistics separately in 
the cumulative system due to the issue with disabling the gathering of 
vacuum statistics.

The patch had some conflicts with the current master branch, but I’ve 
resolved them and now it applies cleanly without conflicts.

On 15.09.2025 23:46, Ilia Evdokimov wrote:
>
> Right now there is a bug: when I run a simple
>
> SELECT * FROM pg_stat_vacuum_database;
>
> psql crashes.
>
> The root cause is an incorrect zeroing of a local variable:
> PgStat_VacuumDBCounts allzero;
> - memset(&allzero, 0, sizeof(PgStat_VacuumRelationCounts));
> + memset(&allzero, 0, sizeof(PgStat_VacuumDBCounts));
>
> -- 
> Best regards,
> Ilia Evdokimov,
> Tantor Labs LLC,
> https://tantorlabs.com
>
>
>
>
>