Horton

Re: Fix parallel vacuum buffer usage reporting

Alena Rybakina <lena.ribackina@yandex.ru>

View thread
From: Alena Rybakina <lena.ribackina@yandex.ru>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Masahiko Sawada <sawada.mshk@gmail.com>
Date: 2024-04-20T12:00:53Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix parallel vacuum buffer usage reporting.

  2. Use bump context for TID bitmaps stored by vacuum

Hi, thank you for your work with this subject.

While I was reviewing your code, I noticed that your patch conflicts 
with another patch [0] that been committed.

[0] 
https://www.postgresql.org/message-id/flat/CA%2BhUKGJkOiOCa%2Bmag4BF%2BzHo7qo%3Do9CFheB8%3Dg6uT5TUm2gkvA%40mail.gmail.com

On 28.03.2024 13:12, Anthonin Bonnefoy wrote:
> Hi,
>
> Thanks for the review.
> On Thu, Mar 28, 2024 at 4:07 AM Masahiko Sawada 
> <sawada.mshk@gmail.com> wrote:
>
>     As for the proposed patch, the following part should handle the
>     temp tables too:
>
>
> True, I've missed the local blocks. I've updated the patch:
> - read_rate and write_rate now include local block usage
> - I've added a specific output for reporting local blocks instead of 
> combining them in the same output.
>
> Regards,
> Anthonin

-- 
Regards,
Alena Rybakina
Postgres Professional:http://www.postgrespro.com
The Russian Postgres Company