Re: Allow GiST opcalsses without compress\decompres functions

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>, Dmitriy Sarafannikov <dsarafannikov@yandex.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-09-20T14:02:35Z
Lists: pgsql-hackers
Alexander Korotkov <a.korotkov@postgrespro.ru> writes:
> On Wed, Sep 20, 2017 at 4:25 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yes.  We don't allow out-of-line values, but we do allow compressed and
>> short-header values.

> BTW, this comment looks still invalid for me...

>> #define SIGLENINT  4 /* >122 => key will *toast*, so very slow!!! */

I haven't done the math to see if 122 is exactly the right value,
but at some point index_form_tuple would decide that the tuple was
uncomfortably big and try to compress it.  So the comment is right
in general terms.

			regards, tom lane


Commits

  1. Allow no-op GiST support functions to be omitted.

  2. Remove no-op GiST support functions in the core GiST opclasses.