Horton

Re: pgsql: Add TAP tests for pg_verify_checksums

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Banck <michael.banck@credativ.de>, Andres Freund <andres@anarazel.de>, Postgres hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Magnus Hagander <magnus@hagander.net>
Date: 2018-10-17T21:30:05Z
Lists: pgsql-hackers 

On 10/16/2018 06:09 PM, Michael Paquier wrote:
> On Mon, Oct 15, 2018 at 11:20:28AM -0400, Andrew Dunstan wrote:
>> On 10/15/2018 11:05 AM, Tom Lane wrote:
>>> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>>>> We should fix this in PG11 rather than ship a broken utility. If
>>>> everyone is happy, I can apply this.
>>> At this point I'd be happier if you waited till after 11.0 wraps...
>>> there is no margin for error today.
> If there is no urgency for this week, could you let me wrap this patch
> then?  I cannot do that this week, but the beginning of next week will
> be fine per the current odds.
>
>


Fine by me.

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix issues with TAP tests of pg_verify_checksums

  2. Use whitelist to choose files scanned with pg_verify_checksums

  3. Add TAP tests for pg_verify_checksums

  4. Work around Msys weakness in Testlib.pm's command_like()