Horton

Re: boolin comment not moved when code was refactored

Vik Fearing <vik@postgresfriends.org>

View thread View on postgr.es
From: Vik Fearing <vik@postgresfriends.org>
To: Peter Smith <smithpb2250@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Richard Guo <guofenglinux@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-10-19T04:26:54Z
Lists: pgsql-hackers 
On 10/19/23 06:17, Peter Smith wrote:
>> In short, maybe the whole comment should just be
>>
>> /*
>>   *      boolin - input function for type boolean
>>   */
>>
> How about "boolin - converts a boolean string value to 1 or 0"


Personally, I do not like exposing the implementation of a boolean (it 
is a base type that is not a numeric), so I prefer Tom's suggestion.
-- 
Vik Fearing

Commits

  1. Doc: modernize comment for boolin().