Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

Ken Kato <katouknl@oss.nttdata.com>

From: katouknl <katouknl@oss.nttdata.com>
To: Suraj Khamkar <khamkarsuraj.b@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2021-10-07T08:14:43Z
Lists: pgsql-hackers

Attachments

Hi,

Thank you for the review.

I wasn't quite sure where to start counting the characters,
but I used pgindent to properly format it, so hopefully everything is 
okay.
Also, I sorted them in alphabetical order just to make it look prettier.
> 	* The below change crosses the 80-character limit in a line. Please
> maintain the same.
> -   "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "ROLE");
> +   "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "TRANSFORM FOR",
> "ROLE");

I made sure there is no whitespaces this time.
> 	* There are trailing whitespaces after
> COMPLETE_WITH_QUERY(Query_for_list_of_languages);.
> Remove these extra whitespaces.
> surajkhamkar@localhost:tab_comment$ git apply
> fix_tab_complete_comment.patch
> fix_tab_complete_comment.patch:38: trailing whitespace.
> COMPLETE_WITH_QUERY(Query_for_list_of_languages);
> warning: 1 line adds whitespace errors.

Best wishes,
Ken Kato

Commits

  1. Improve psql tab completion for COMMENT