Horton

Re: [PATCH v2] src/port/snprintf.c: Optimize the common base=10 case in fmtint

Chapman Flack <chap@anastigmatix.net>

View thread View on postgr.es
From: Chapman Flack <chap@anastigmatix.net>
To: Arjan van de Ven <arjan@linux.intel.com>, Tom Lane <tgl@sss.pgh.pa.us>, Japin Li <japinli@hotmail.com>
Cc: pgsql-hackers@postgresql.org, mark.dilger@enterprisedb.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Date: 2021-10-27T23:50:45Z
Lists: pgsql-hackers 
On 10/27/21 18:18, Arjan van de Ven wrote:
> +        /*
> +         * Special case each of the possible base values  (8, 10, 16) to
> avoid an
> +         * expensive divide operation
> +         * (the compiler will use a multiply, shift or boolean ops for this)
> +         */


Was 'boolean' the intended word there? To me it is distinct from 'bitwise'.

Regards,
-Chap

Commits

  1. Speed up printing of integers in snprintf.c.