Horton

Re: POC, WIP: OR-clause support for indexes

Alena Rybakina <lena.ribackina@yandex.ru>

View thread
From: Alena Rybakina <lena.ribackina@yandex.ru>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: Andrey Lepikhov <a.lepikhov@postgrespro.ru>, Marcos Pegoraro <marcos@f10.com.br>, teodor@sigaev.ru, PostgreSQL-development <pgsql-hackers@postgresql.org>, Tomas Vondra <tomas.vondra@enterprisedb.com>, Peter Geoghegan <pg@bowt.ie>
Date: 2023-07-11T12:29:21Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Make group_similar_or_args() reorder clause list as little as possible

  2. Allow usage of match_orclause_to_indexcol() for joins

  3. Skip not SOAP-supported indexes while transforming an OR clause into SAOP

  4. Remove the wrong assertion from match_orclause_to_indexcol()

  5. Teach bitmap path generation about transforming OR-clauses to SAOP's

  6. Transform OR-clauses to SAOP's during index matching

  7. Fix the value of or_to_any_transform_limit in postgresql.conf.sample

  8. Transform OR clauses to ANY expression

  9. MergeAttributes code deduplication

  10. SEARCH and CYCLE clauses

  11. Improve estimation of OR clauses using extended statistics.

  12. Teach btree to handle ScalarArrayOpExpr quals natively.

  13. Revise collation derivation method and expression-tree representation.

  14. Instead of trying to force WHERE clauses into CNF or DNF normal form,

Attachments

Hi!

On 10.07.2023 15:15, Ranier Vilela wrote:
> Em seg., 10 de jul. de 2023 às 09:03, Ranier Vilela 
> <ranier.vf@gmail.com> escreveu:
>
>     Hi Alena,
>
>     Em seg., 10 de jul. de 2023 às 05:38, Alena Rybakina
>     <lena.ribackina@yandex.ru> escreveu:
>
>         I agreed with the changes. Thank you for your work.
>
>         I updated patch and added you to the authors.
>
>         I specified Ranier Vilela as a reviewer.
>
>     Is a good habit when post a new version of the patch, name it v1,
>     v2, v3,etc.
>     Makes it easy to follow development and references on the thread.
>
Sorry, I fixed it.
>
>     Regarding the last patch.
>     1. I think that variable const_is_left is not necessary.
>     You can stick with:
>     + if (IsA(get_leftop(orqual), Const))
>     + nconst_expr =get_rightop(orqual);
>     + const_expr = get_leftop(orqual) ;
>     + else if (IsA(get_rightop(orqual), Const))
>     + nconst_expr =get_leftop(orqual);
>     + const_expr = get_rightop(orqual) ;
>     + else
>     + {
>     + or_list = lappend(or_list, orqual);
>     + continue;
>     + }
>
Agreed.
>
>
>     2. Test scalar_type != RECORDOID is more cheaper,
>     mainly if OidIsValid were a function, we knows that is a macro.
>     + if (scalar_type != RECORDOID && OidIsValid(scalar_type))
>
Is it safe? Maybe we should first make sure that it can be checked on 
RECORDOID at all?
>
>     3. Sorry about wrong tip about array_type, but if really necessary,
>     better use it.
>     + newa->element_typeid = scalar_type;
>     + newa->array_typeid = array_type;
>
Agreed.
>
>
>     4. Is a good habit, call free last, to avoid somebody accidentally
>     using it.
>     + or_list = lappend(or_list, gentry->expr);
>     + list_free(gentry->consts);
>     + continue;
>
No, this is not necessary, because we add the original expression in 
these places to the resulting list and later
we will not use the list of constants for this group at all, otherwise 
it would be an error.

-- 
Regards,
Alena Rybakina
Postgres Professional