Horton

Conflicting option checking in pg_restore

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2018-10-27T21:01:06Z
Lists: pgsql-hackers

Attachments

Checking for conflicting options in pg_restore was mostly done in main() with
one check deferred until RestoreArchive().  Reading the git history makes it
seem like it simply happened, without the disjoint checking being intentional.
Am I reading it right that we can consolidate all the option checking to
main()?  The attached patch does that, and also rewords the error message to
make it similar to the other option checks.

cheers ./daniel

Commits

  1. Consolidate cross-option checks in pg_restore

  2. Throw an error when using -C and -1 at the same time in pg_restore.