Horton

Re: Postgres perl module namespace

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Noah Misch <noah@leadboat.com>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Mark Dilger <mark.dilger@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-19T18:54:58Z
Lists: pgsql-hackers

Attachments

On 9/7/21 7:43 AM, Andrew Dunstan wrote:
> On 9/6/21 1:08 AM, Michael Paquier wrote:
>> On Sat, Sep 04, 2021 at 09:58:08AM -0400, Andrew Dunstan wrote:
>>> On 9/4/21 2:19 AM, Noah Misch wrote:
>>>> plperl uses PostgreSQL:: as the first component of its Perl module namespace.
>>>> We shouldn't use both PostgreSQL:: and Postgres:: in the same source tree, so
>>>> this change should not use Postgres::. 
>>> Good point. Here's the same thing using PostgreSQL::Test
>> A minor point: this introduces PostgreSQL::Test::PostgresVersion.
>> Could be this stripped down to PostgreSQL::Test::Version instead?
>
>
> That name isn't very clear - what is it the version of, PostgreSQL or
> the test?
>
> There's nothing very test-specific about this module - it simply
> encapsulates a Postgres version string. So maybe it should just be
> PostgreSQL::Version.
>
>


Discussion has gone quiet and the tree is now relatively quiet, so now
seems like a good time to do this. See attached patches.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Fix PostgreSQL::Test aliasing for Perl v5.10.1.

  2. For PostgreSQL::Test compatibility, alias entire package symbol tables.

  3. Make PostgresNode easily subclassable