Re: Wait event that should be reported while waiting for WAL archiving to finish

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es

From: Fujii Masao <masao.fujii@oss.nttdata.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Michael Paquier <michael@paquier.xyz>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2020-02-17T07:30:00Z

Lists: pgsql-hackers

Attachments

wait_event_wal_archive_v3.patch (text/plain) patch v3


On 2020/02/14 23:43, Robert Haas wrote:
> On Thu, Feb 13, 2020 at 10:47 PM Fujii Masao
> <masao.fujii@oss.nttdata.com> wrote:
>> Fixed. Thanks for the review!
> 
> I think it would be safer to just report the wait event during
> pg_usleep(1000000L) rather than putting those calls around the whole
> loop. It does not seem impossible that ereport() or
> CHECK_FOR_INTERRUPTS() could do something that reports a wait event
> internally.

OK, so I attached the updated version of the patch.
Thanks for the review!

Regards,

-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters

Commits

Add wait events for WAL archive and recovery pause.
- b8e20d6dabda 13.0 landed
Add description about GSSOpenServer wait event into document.
- 0b5474181569 12.3 landed
- f4ae7221413d 13.0 landed
Add description about LogicalRewriteTruncate wait event into document.
- 1beab076cefe 10.13 landed
- 12bea22a78c1 11.8 landed
- 6c221aa56e18 12.3 landed
- e593148d43ad 13.0 landed
GSSAPI encryption support
- b0b39f72b990 12.0 cited
Create and use wait events for read, write, and fsync operations.
- 249cf070e367 10.0 cited