Horton

Re: 002_types.pl fails on some timezones on windows

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Peter Eisentraut <peter_e@gmx.net>, Petr Jelinek <petr@2ndquadrant.com>
Date: 2021-10-01T14:25:55Z
Lists: pgsql-hackers 
On 9/30/21 3:38 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 9/30/21 2:36 PM, Andres Freund wrote:
>>> CI showed me a failure in 002_types.pl on windows. I only just now noticed
>>> that because the subscription tests aren't run by any of the vcregress.pl
>>> steps :(
>> We have windows buildfarm animals running the subscription tests, e.g.
>> <https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=drongo&dt=2021-09-29%2019%3A08%3A23&stg=subscription-check>
>> and they do it by calling vcregress.pl.
> But are they running with the prevailing zone set to "Greenwich Standard
> Time"?


drongo's timezone is set to plain "UTC".


It also offers me "UTC+00:00(Dublin, Edinburgh, Lisbon, London)" and
"UTC+00:00(Monrovia, Reykjavik)"


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Doc: improve timezone/README's recipe for tracking Windows zones.

  2. Update our mapping of Windows time zone names some more.

  3. Update our mapping of Windows time zone names using CLDR info.

  4. Re-alphabetize the win32_tzmap[] array.

  5. Remove gratuitous environment dependency in 002_types.pl test.