Thread

Re: Fix redundant memset after palloc0 in heap_form_minimal_tuple()

Jeff Davis <pgsql@j-davis.com> — 2025-11-04T17:51:18Z

On Tue, 2025-11-04 at 17:05 +0800, Chao Li wrote:
> The current code does both palloc0() and memset(0)
> in heap_form_minimal_tuple():

Thank you, fixed.

> To fix the problem, my first impression was to delete the memset().
> But looking at a0942f4, I found a couple of other places that do the
> same pattern: palloc(len+extra) then memset(0, extra), so I think the
> correct fix should be changing the palloc0 to palloc.

The palloc0() is important because heap_fill_tuple() skips over
alignment bytes. So I just removed the memset().

Regards,
	Jeff Davis