Horton

Re: Patch: Add parse_type Function

David E. Wheeler <david@justatheory.com>

View thread View on postgr.es
From: "David E. Wheeler" <david@justatheory.com>
To: jian he <jian.universality@gmail.com>
Cc: Erik Wienhold <ewie@ewie.name>, Tom Lane <tgl@sss.pgh.pa.us>, Pavel Stehule <pavel.stehule@gmail.com>, Jim Jones <jim.jones@uni-muenster.de>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, pgsql-hackers@lists.postgresql.org
Date: 2024-02-20T14:44:48Z
Lists: pgsql-hackers

Attachments

On Feb 20, 2024, at 01:30, jian he <jian.universality@gmail.com> wrote:

> the second hint `-- grammar error expected` seems to contradict with
> the results?

Quite right, thank you, that’s actually a trapped error. I’ve tweaked the comments and their order in v7, attached.

This goes back to the discussion of the error raising of to_regtype[1], so I’ve incorporated the patch from that thread into this patch, and set up the docs for to_regtypemod() with similar information. The wording is still a little opaque for my taste, though, written more for someone who knows a bit about the internals, but it’s a start.

I’ve also fixed the wayward parameter in the function signature in the docs, and added a note about why I’ve also patched genbki.pl.

Best,

David

[1] https://www.postgresql.org/message-id/flat/57E1FDDC-5A38-452D-82D7-A44DA2E13862%40justatheory.com#1ae0b11634bc33c7ad3cd728e43d504e

Commits

  1. Add to_regtypemod function to extract typemod from a string type name.

  2. Remove "#ifdef WIN32" guards from src/port/win32*.c