Re: renameatt() can rename attribute of index, sequence, ...
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: KaiGai Kohei <kaigai@ak.jp.nec.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-03-13T01:08:23Z
Lists: pgsql-hackers
2010/3/11 KaiGai Kohei <kaigai@ak.jp.nec.com>: > (2010/03/11 23:55), Robert Haas wrote: >> 2010/3/10 KaiGai Kohei<kaigai@ak.jp.nec.com>: >>> Indeed, it is useful to allow renaming attribute of composite types. >>> >>> However, it is also useless to allow to rename attribute of sequences, >>> but harmless, like renames on indexes. It seems to me it is fair enough >>> to allow renaming attributes of tables, views and composite types... >> >> I don't agree. I think users should be allowed to rename things they >> had a hand in naming in the first place (and index columns fall into >> that category, since the names are derived from table column names). >> But changing system-assigned column names for sequences or toast >> tables is just weird. > > OK, the attached patch forbid to rename an attribute of relations except > for tables, views, composite types and indexes. I would like to apply this for 9.0, with some adjustments to the comments. Objections? ...Robert