Re: [PATCH] Provide rowcount for utility SELECTs
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Boszormenyi Zoltan <zb@cybertec.at>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@commandprompt.com>, Peter Eisentraut <peter_e@gmx.net>, Hans-Juergen Schoenig <hs@cybertec.at>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-02-12T18:38:11Z
Lists: pgsql-hackers
On Fri, Feb 12, 2010 at 1:22 PM, Boszormenyi Zoltan <zb@cybertec.at> wrote: > Robert Haas írta: >> On Fri, Feb 12, 2010 at 10:48 AM, Boszormenyi Zoltan <zb@cybertec.at> wrote: >> >>> I added a small change to protocol.sgml for the >>> "CommandComplete" message describing the change. >>> Is it enough? >>> >> >> Ah, I didn't even see that that section needed to be updated. Good >> catch. I'd suggest the following wording: >> >> For a <command>SELECT</command> or <command>CREATE TABLE AS</command> >> command, the tag is SELECT rows... [and the rest as you have it] >> >> We should probably also retitle that section from "Retrieving Result >> Information for Other Commands" to "Retrieving Other Result >> Information" and adjust the text of the opening sentence similarly. >> >> Also I think you need to update the docs for PQcmdtuples to mention >> that it not works for SELECT and CTAS. >> > > Ok, I will update libpq.sgml where this section resides. > What's a CTA, btw? Do you mean CTE, a.k.a. "Common Table Expression"? Sorry, CTAS = CREATE TABLE AS SELECT. ...Robert