Re: Review: listagg aggregate

On Fri, Jan 29, 2010 at 2:43 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
> 2010/1/28 Tom Lane <tgl@sss.pgh.pa.us>:
>> Pavel Stehule <pavel.stehule@gmail.com> writes:
>>> with get_fn_expr_arg_stable() we are able to fix second parameter
>>> without some performance issues.
>>
>> No, that will create its own performance issues ---
>> get_fn_expr_arg_stable isn't especially cheap.
>> If there were a really strong reason why we had to do it,
>> then I'd agree, but frankly the argument for disallowing
>> a variable delimiter is too thin.
>
> it could be called only once. But I agree, so could be better, check
> it in parser time.
>
> ok - I am only one who like original behave - so I  am withdrawing.
> Robert, If you like, please commit Itagaki's patch. + add note about
> behave when second parameter isn't stable.

I haven't even looked at this code - I sort of assumed Itagaki was
handling this one.  But it might be good to make sure that the docs
have been read through by a native English speaker prior to commit...

...Robert