Re: Review: listagg aggregate

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: "David E. Wheeler" <david@kineticode.com>

Cc: Pavel Stehule <pavel.stehule@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>, "pgsql-hackers@postgresql.org Hackers" <pgsql-hackers@postgresql.org>

Date: 2010-01-29T18:46:50Z

Lists: pgsql-hackers

On Fri, Jan 29, 2010 at 1:45 PM, David E. Wheeler <david@kineticode.com> wrote:
> On Jan 29, 2010, at 10:43 AM, Robert Haas wrote:
>
>> I haven't even looked at this code - I sort of assumed Itagaki was
>> handling this one.  But it might be good to make sure that the docs
>> have been read through by a native English speaker prior to commit...
>
> I did and revised them slightly. There isn't much, just a brief comment in the table of aggregate functions. The documentation for all the functions on that page could use a little love, frankly.

Want to take a short at it?

...Robert