Re: Red-black tree for GIN
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2010-01-24T15:26:00Z
Lists: pgsql-hackers
2010/1/24 Teodor Sigaev <teodor@sigaev.ru>: >> 3. This code could really use some more comments, and maybe some of >> the variable names could be better chosen, too. It's far from obvious >> what is going on here. I studied rbtrees in college and I still >> remember more or less how they work, but, boy, this is hard to follow. >> The names of the iterator states are truly horrible, at least IMO. > > I changed names and slightly improve comments. Would it be OK if I went through here and hacked on the comments and sent this back to you? ...Robert