Re: attoptions

Robert Haas <robertmhaas@gmail.com>

View thread

From: Robert Haas <robertmhaas@gmail.com>

To: Alex Hunsaker <badalex@gmail.com>

Cc: pgsql-hackers@postgresql.org

Date: 2010-01-21T02:51:32Z

Lists: pgsql-hackers

Attachments

attoptions-v3.patch (text/x-patch) patch v3

On Tue, Jan 19, 2010 at 10:51 AM, Alex Hunsaker <badalex@gmail.com> wrote:
> But yes, lets keep it simple for now.

OK.  Updated patch attached.  Changes:

- Incorporate your previous review patch.
- Omit attacl and attoptions from hardcoded relation descriptor
initializers so the whole thing still builds.- Use
ATSimplePermissionsRelationOrIndex instead of custom permissions
logic.
- Remove recursion, per further thought about a comment in your
original review - I agree that the recursive behavior is weird.
- Remove a stray reference to SET STATISTICS DISTINCT in the documentation.
- Bug fix: this wasn't working at all for index-expression columns.

...Robert