Re: Feature patch 1 for plperl [PATCH]

On Sun, Jan 10, 2010 at 2:58 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
> I don't know why you would do either of these things. I at least would load
> one module which would in turn load others. So I'd expect to see something
> like this:
>
>   plperl.on_perl_init = 'use lib "/my/app"; use MyApp::Pg;'
>
> I think the suggestion that somehow people will want to put a huge list of
> directives straight into postgresql.conf and that this is a reason not to
> provide this facility is on the wrong track completely.

Hmm.  I have to admit I didn't think about "use lib".  That does seem
like a plausible thing to want to do.

>> I would strongly suggest to Tim that he rip the portions of this patch
>> that are related to this feature out and submit them separately so
>> that we can commit the uncontroversial portions first.
>
> See my previous email. I suggested that Tim send three patches: one for this
> controversial stuff, one for the new utility functions for plperl, and one
> for the remainder. He and I have discussed it and I believe he is agreeable
> to that.

OK, well then just +1 for that.

...Robert