Re: [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Daniel Farina <drfarina@acm.org>
Cc: Greg Smith <greg@2ndquadrant.com>, Jeff Davis <pgsql@j-davis.com>, Simon Riggs <simon@2ndquadrant.com>, Hannu Krosing <hannu@krosing.net>, Daniel Farina <dfarina@truviso.com>, pgsql-hackers@postgresql.org
Date: 2009-12-30T05:58:55Z
Lists: pgsql-hackers
On Wed, Dec 30, 2009 at 12:56 AM, Daniel Farina <drfarina@acm.org> wrote: > On Tue, Dec 29, 2009 at 9:46 PM, Robert Haas <robertmhaas@gmail.com> wrote: >> Sure. If you think you can make it work using bytea, that seems >> clearly better than using an internal type, all things being equal. > > I think both are perfectly viable and can be supported simultaneously, > actually...I simply like INTERNAL because the mechanism and passed > data structure for when you *do* want to write a C function is just > really crisp and simple, and is not going to be a source of overhead. OK. I think we'll have to see the proposed patch before we can really make a final judgement on this, but hopefully I've at least given you enough feedback/food for thought to move this forward in a meaningful way... ...Robert