Re: Patch: Remove gcc dependency in definition of inline functions
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Kurt Harriman <harriman@acm.org>
Cc: Marko Kreen <markokr@gmail.com>, pgsql-hackers@postgresql.org
Date: 2009-12-16T05:42:00Z
Lists: pgsql-hackers
On Tue, Dec 15, 2009 at 10:34 PM, Kurt Harriman <harriman@acm.org> wrote: >> Your worry ii) can be ignored, managing to compile on such >> compilers is already overachievement. > > I think so too. With your opinion added to mine, do we constitute a > consensus of the pg community? Someone might object that a sample of > two individuals is insufficiently representative of the whole, but > away with the pedants: let us not quibble over trifles. I haven't completely followed this thread, but I think there has been some discussion of making changes to inline that would cause regressions for people using old, crappy compilers, and I think we should avoid doing that unless there is some compelling benefit. I'm not sure what that benefit would be - I don't think "cleaner code" is enough. ...Robert