Re: bug: fuzzystrmatch levenshtein is wrong

Robert Haas <robertmhaas@gmail.com>

View thread

From: Robert Haas <robertmhaas@gmail.com>

To: Bruce Momjian <bruce@momjian.us>

Cc: marcin mank <marcin.mank@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2009-12-09T02:45:25Z

Lists: pgsql-hackers

Attachments

levenshtein.diff (application/octet-stream) patch

On Tue, Dec 8, 2009 at 9:08 PM, Bruce Momjian <bruce@momjian.us> wrote:
> Robert Haas wrote:
>> > patch attached.
>>
>> I cannot get this patch to apply for anything.  All 4 hunks fail, both
>> on HEAD and on the the pre-8.4-pgindent version of fuzzystrmatch.c.
>> Either I'm doing something wrong here, or there's something wrong with
>> this patch file.
>
> The author converted tabs to spaces --- there is not a single tab in the
> diff file.

Ah.  I knew there had to be a reason.

I'm attaching my version of this patch.  Barring objections, I am
going to apply this to HEAD and backpatch to 8.4, where this feature
(and the associated bug) were introduced.

...Robert