Re: bug: json format and auto_explain

On Mon, Dec 7, 2009 at 10:42 AM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> Tom Lane wrote:
>> Euler Taveira de Oliveira <euler@timbira.com> writes:
>> > While testing the EXPLAIN BUFFERS patch I found a bug. I'm too tired to
>> > provide a fix right now but if someone can take it I will appreciate. It seems
>> > ExplainJSONLineEnding() doesn't expect es->grouping_stack list as a null pointer.
>>
>> Looks like auto_explain is under the illusion that it need not call
>> ExplainBeginOutput/ExplainEndOutput.
>
> Fortunately the author of auto_explain can now commit the fix by himself ...
> Kudos, BTW :-)

I just tested and this has been broken since it was committed (by
Tom).  However, I believe I did test it on the last version of the
patch that I submitted, and I think it worked then.  So we have lots
of choices for who should fix this:

- me, since it's my feature
- Tom, since it appears that he broke it
- Itagaki-san, since he's the auto_explain maintainer

:-)

...Robert