Re: CommitFest 2009-09, two weeks on

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Alvaro Herrera <alvherre@commandprompt.com>

Cc: Boszormenyi Zoltan <zb@cybertec.at>, Michael Meskes <meskes@postgresql.org>, Dan Colish <dan@unencrypted.org>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org, Hans-Juergen Schoenig <hs@cybertec.at>

Date: 2009-11-12T20:07:27Z

Lists: pgsql-hackers

On Thu, Nov 12, 2009 at 2:49 PM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> Boszormenyi Zoltan escribió:
>> Alvaro Herrera írta:
>
>> > I have applied this patch after some tinkering.  I mainly added support
>> > for "fetch_args: FORWARD opt_from_in name" and "BACKWARD opt_from_in
>> > name" in ecpg.addons which apparently you forgot.
>>
>> Thanks. Your fix is correct if this patch is considered
>> standalone. This means I have to re-post the later
>> patches to fix the reject this fix causes in them.
>
> Yeah.  BTW I don't think the rest of the pieces in this series make
> sense to apply separately, because they don't do anything useful by
> themselves (one of them introduces an unused function, what good is in
> that?).  I think they should be submitted as a single patch.
>
> If you want to submit patches in a series like this one, they need to be
> considered standalone, I think.  The Linux kernel devs work differently
> than us here.

Zoltan broke them up because Michael asked him to do so.

...Robert