Horton

Re: Useless parameter 'cur_skey' in IndexScanOK

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Hugo Zhang <hugo.zhang@openpie.com>
Date: 2024-07-03T13:46:56Z
Lists: pgsql-hackers 
> On 3 Jul 2024, at 15:41, Aleksander Alekseev <aleksander@timescale.com> wrote:
>> The 'cur_skey' parameter in `IndexScanOK` funciton doesn't seem to be useful.

> Good catch. As I understand it is not used for anything since
> a78fcfb51243 (dated 2006) and this is a static function, so we
> shouldn't worry about third-party extensions.

Agreed, it seems reasonable to clean this up.

> I wonder why none of the compilers complained about this.

Not to mention static analyzers.

--
Daniel Gustafsson

Commits

  1. Remove unused 'cur_skey' argument from IndexScanOK()